CST 338 Week 3

Shapes Lab Code Review

I evaluated Anthony Torres and Zeyad Abdelkader from my group. Their code was clean and concise throughout. Both of their variable names and formatting were excellent and easy to read. For Anthony, every method had comments that explained what they do and what they return. Zeyad's was missing comments much like mine, but everything else looked good. Both had very efficient logic, no unused warnings, and their unit tests all passed.

 

Feedback I got:

Both told me that my code was lacking comments and some parts were unfinished. Variable names and formatting that did exist were good, but could be cleaned up a little.

 

 

  • What improvements would you make to your code/what was suggested? 

    I absolutely need to improve at setting comments as I work. I tend to leave them until after and end up forgetting about them. My unit tests were also a bit chaotic and not as thorough as they could be.

  • Which unit tests were the hardest to pass?

    Testing the ShapeReader's shapesFromFile() was the hardest at the time. I didn't have a full understanding of how to create a test file for this unit test and how to have scanner read from it.

  • How do the existing tests function and could they be improved?
    1. Do the existing unit tests cover the full range of the sub classes?

      No, I had missing unit tests such as ShapeReader's. Aside from that, I also messed up with the repository and one of the tests I wrote in the previous week was lost.
       
    2. How would you change the unit tests?
      1. Keep in mind I do not want them to change but this doesn't mean I think they are perfect.  Reading through the tests is a good way to learn what the code should do thinking about how to test the codeis a good way to learn how to make tests.

        I think the unit tests I had could've been more extensive. Some of them ended up being a single assertEquals or assertNotEquals with a local variable.
  • What did you struggle with?

    •  The scanner, file, and try/catch were all very difficult for me and not included when I turned in the file originally. I think I could do them now.

  • What did one of your teammates struggle with?
  • Was any part of the code a struggle for YOU?

    Several parts as I was still getting used to Java and relearning many programming concepts.

  • Was any part of writing the code easy for YOU?

    •  Once I had an understanding of how Dr C. wanted us to write unit tests, the getters and setters became particularly easy.

  • What was your biggest Lab victory?

    Nothing specific. Just being able to look at this code and mostly understand it now feels like a big victory.

    • Comments

    Post a Comment

    Popular posts from this blog

    CST349 & CST300 Week 4

    Part One: Set your educational goals  My goals over the next two years are to master the fundamentals of programming as well as network with my peers. The ETS Computer Science Test will be a good measure. I will aspire to score in the 95th percentile or higher. Part Two: Set your career goals   My long term goal would be to get into a big tech company in a big city. Working at Riot Games in LA would be a dream come true. I plan to continue networking, taking on internships, and training my skills to hopefully make it one day. In the meantime, I plan to look for more feasible jobs for someone still attending college or freshly graduated in the Computer Science field. Any job that challenges my abilities and allows me to live a comfortable daily life is acceptable.     Part Three: Take a wild guess of your percentile of the ETS Computer Science test Based on my current programming skills and the sample questions shown, I feel somewhat confident but clearly also in need...
    Read more

    CST 349 & CST300 Week 2

    Image
      Part 1: Review and Reflect Learning Strategy In general, I have a lot of confidence in the strategies listed for test-taking. My weaknesses are related to my schedule and the way I study. My strengths with regards to learning strategies are in my meticulous note-taking, ability to parse the main idea in a passage, and surveying objective examinations so I can plan out how I want to tackle them. As for three areas where I could improve: Making and revisiting a schedule, Asking myself questions about the content as I learn it, and coming back to review or study. I often end up studying at bad times due to inflexibility with my own scheduling.  Part 2: Preview Time Management Skills Part 3: Project Management Basics Introduction to Project Management: Projects have a unique specified start and end date as well as a specific goal that determine its "scope." A project must relate to a business strategy. Factors that may call for a company to initiate a project: Market need, bu...
    Read more

    CST 349 and CST 300 - Week 1 Learning Journal

         The first week of my journey through the CSUMB Computer Science Online program has come to a close. It was hectic: our group was scrambling to find a meeting time and get everyone connected on Slack while some of us were still recovering from illnesses we got over the holidays.      In CST 349, we learned about the history and staff behind CSUMB as well as effective methods of learning online and being professional while operating in group environments. We also built the foundations for the rest of the program and hopefully our future careers with the setup of these blogs, LinkedIn profiles, and meeting all of our peers. AI was also a focus as we discussed the ChatGPT prompts we found most useful for educational purposes.      In CST 300, we reviewed the concepts behind academic writing and created outlines for a future industry analysis essay. I chose to focus my outline on software engineering and the company Riot Games. It's a place t...
    Read more