CST 338 Week 4

 Part 1 – Peer Code Review Session

 

I reviewed Zeyad Abdelkader’s and Anthony Torres’s code (from my group). 

Both had very similar and clean code, so this section will cover both: {

Encapsulation:

Are instance variables private?:white_check_mark:

Do getters and setters exist where appropriate?:white_check_mark:

 

Constructors: 

Does the constructor validate its inputs? What happens if someone passes an invalid suit or value?:x: (Should add this)

Is there a default constructor? Should there be one for Card? For Deck?:white_check_mark:

 Yes, there should always be a default constructor.

 

Readability and Style:

Can you follow the logic without running the code? :white_check_mark:

Does the code follow the Google Java Style Guide in terms of naming, braces, and spacing? :white_check_mark: (Class names UpperCamelCase, methods and fields lowerCamelCase)

No case for a negative drawCards:x:

Code is easy to follow and readable, variable names are simple and informative :white_check_mark:


}


Say it out loud:

Everything looks really good , I think the only thing is for Zeyad to add the javadoc method comments for everything that's not generated. For Anthony’s everything is very similar to mine without the bugs, and Zeyad’s but with comments.

 

Part 2 – Written Reflection

 

1. Your Approach and What It Revealed


I went right into coding instead of coming up with a plan. I started with Card just because it's more specific and since cards are what make up a deck. I'd say my approach is pretty indicative of how I approach problems and learning in general. I always go straight in and try to figure things out as I go. I'd say it was effective for understanding what makes up the cards that would go into the deck. I think looking into the overall structure first before beginning would be effective, and I will consider doing it in future projects. 

 

 

2. The Peer Review: What You Saw and What You Learned

I worked with Zeyad and Anthony for my peer review. Their methods for equals were a lot cleaner than mine, with Zeyad setting up using this.suit and this.rank with other.suit and other.rank as opposed to mine which used, for example, getSuit() and object.getSuit(). I think Zeyad's approach is far more readable and makes sense as to what is being compared. I got an incredible piece of advice from Zeyad: my drawCard() and drawCards() methods were drawing from different spots. drawCard was drawing from the end while drawCards was drawing from the front. I didn't even realize I had this bug as all the tests had been passing.


3. Consolidating the OOP Concepts

I have actually had some experience with OOP from my old C++ classes. I struggled a lot in those classes and I think Java actually did a great job at making the concepts more approachable. I still have nightmares about asking for help and being told that I "referenced a null pointer." That said, I still learned a lot about the structure of java and autogenerated methods (I love these.) 

toString() is the one I learned the most about, while enums are the thing I am the most shaky on still.

toStrings take a bunch of data and turns it into a readable string of text.

 enums have something to do with fixed sets of values that are grouped logically, but I don't fully get where I'd be using them yet.


4. Did you celebrate?


I always breathe a sigh of relief and spend a day playing games and unwinding at the end of the week, and this was no different. I wouldn't say that I celebrated to any particularly higher degree this time than usual, but I took my time to relax and de-stress. I might go out and get a special meal to celebrate at the end of this whole project. 



Comments

Post a Comment

Popular posts from this blog

CST349 & CST300 Week 4

Part One: Set your educational goals  My goals over the next two years are to master the fundamentals of programming as well as network with my peers. The ETS Computer Science Test will be a good measure. I will aspire to score in the 95th percentile or higher. Part Two: Set your career goals   My long term goal would be to get into a big tech company in a big city. Working at Riot Games in LA would be a dream come true. I plan to continue networking, taking on internships, and training my skills to hopefully make it one day. In the meantime, I plan to look for more feasible jobs for someone still attending college or freshly graduated in the Computer Science field. Any job that challenges my abilities and allows me to live a comfortable daily life is acceptable.     Part Three: Take a wild guess of your percentile of the ETS Computer Science test Based on my current programming skills and the sample questions shown, I feel somewhat confident but clearly also in need...
Read more

CST 349 & CST300 Week 2

Image
  Part 1: Review and Reflect Learning Strategy In general, I have a lot of confidence in the strategies listed for test-taking. My weaknesses are related to my schedule and the way I study. My strengths with regards to learning strategies are in my meticulous note-taking, ability to parse the main idea in a passage, and surveying objective examinations so I can plan out how I want to tackle them. As for three areas where I could improve: Making and revisiting a schedule, Asking myself questions about the content as I learn it, and coming back to review or study. I often end up studying at bad times due to inflexibility with my own scheduling.  Part 2: Preview Time Management Skills Part 3: Project Management Basics Introduction to Project Management: Projects have a unique specified start and end date as well as a specific goal that determine its "scope." A project must relate to a business strategy. Factors that may call for a company to initiate a project: Market need, bu...
Read more

CST 349 and CST 300 - Week 1 Learning Journal

     The first week of my journey through the CSUMB Computer Science Online program has come to a close. It was hectic: our group was scrambling to find a meeting time and get everyone connected on Slack while some of us were still recovering from illnesses we got over the holidays.      In CST 349, we learned about the history and staff behind CSUMB as well as effective methods of learning online and being professional while operating in group environments. We also built the foundations for the rest of the program and hopefully our future careers with the setup of these blogs, LinkedIn profiles, and meeting all of our peers. AI was also a focus as we discussed the ChatGPT prompts we found most useful for educational purposes.      In CST 300, we reviewed the concepts behind academic writing and created outlines for a future industry analysis essay. I chose to focus my outline on software engineering and the company Riot Games. It's a place t...
Read more